Test passive reviews #35

2bndy5 · 2024-06-04T05:30:04Z

No description provided.

github-actions

Cpp-linter Review

Only 0 out of 6 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/demo.cpp b/src/demo.cpp
index 106c0a6..20165b9 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +2,0 @@
-#include <cstdio>
@@ -4,0 +4 @@
+#include <cstdio>
diff --git a/src/demo.hpp b/src/demo.hpp
index 2d1a397..5a6d7a6 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +2,0 @@
-
-
@@ -9,2 +7,3 @@ class Dummy {
-    public:
-    void *not_usefull(char *str){
+public:
+    void* not_usefull(char* str)
+    {
@@ -16,23 +15 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {
@@ -40 +16,0 @@ struct LongDiff
-

Have any feedback or feature suggestions? Share it here.

github-actions · 2024-06-04T05:42:25Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 2 file(s) not formatted

src/demo.cpp
src/demo.hpp

clang-tidy reports: 6 concern(s)

src/demo.cpp:7:8: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function

size_t dummyFunc(size_t i) { return i; }
~~~~~~ ^
auto                       -> size_t

src/demo.cpp:9:5: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
int main()
~~~ ^
auto       -> int
```
src/demo.cpp:11:13: warning: [readability-braces-around-statements]

statement should be inside braces
```
    for (;;)
            ^
             {
```
src/demo.cpp:14:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions
```
    printf("Hello world!\n");
    ^
```

src/demo.hpp:10:11: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function

    void *not_usefull(char *str){
    ~~~~~~^
    auto                         -> void *

src/demo.hpp:12:16: warning: [modernize-use-nullptr]

use nullptr

        return 0;
               ^
               nullptr

Have any feedback or feature suggestions? Share it here.